test(realunit): cover NewRegistration with null userData (first-time empty form)#708
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
test(realunit): cover NewRegistration with null userData (first-time empty form)#708joshuakrueger-dfx wants to merge 1 commit into
joshuakrueger-dfx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up coverage for the
KycRequired→NewRegistrationempty-form fix(#705, consuming api#3836).
#705 removed the
parses KycRequiredtest but did not add a case for thestate the fix actually exists for: a first-time user gets
NewRegistrationwith no
userData, and the app must render an empty form. This pinsthat contract so a regression (e.g. re-introducing a non-empty expectation)
fails loudly.
Changes
aggregate_dtos_test.dart— addparses NewRegistration with null userData (first-time user → empty form), assertingstate == newRegistrationandrealUnitUserDataDto == null.Test-only, no production code touched.